Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid folder disappears when expand root #67

Closed
wants to merge 3 commits into from

Conversation

hieuwu
Copy link
Collaborator

@hieuwu hieuwu commented Feb 15, 2024

Summary
Fix ARK-Builders/arklib-android#150

Before

Expand.issue.when.tap.on.expand.button.in.root.folder.mov

After:

Fix.for.collapsible.device.root.mov

@hieuwu hieuwu self-assigned this Feb 15, 2024
@hieuwu hieuwu changed the title (draft) Avoid folder disappears when expand root Avoid folder disappears when expand root Feb 17, 2024
@hieuwu hieuwu marked this pull request as ready for review February 17, 2024 02:23
Copy link
Member

@mdrlzy mdrlzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good solution, but we will prohibit adding device root as ark root anyway, so this code is not needed as it adds unnecessary complexity
Related issue

@mdrlzy mdrlzy closed this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Folders disapear when tap on chevron button in root item
2 participants