Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13: Seperate Link Creation Dialog #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mberry
Copy link
Collaborator

@mberry mberry commented Oct 1, 2023

  • Adds a Save button which opens the link creation form
  • Will also open on ctrl+v and paste the url
  • Only shows url field at first, then autofills with title
  • Has a 1500ms debounce to keep meta fields from opening prematurely if the user is typing the address, will increase by 750ms each time it's triggered
  • Closes dialog form after link created or Hide button is clicked

The Hide/Save button isn't fixed width and has a small redraw on click.

Closes:

Will also open on ctrl+v and paste the url
Only shows url field at first, then autofills with title
Has a 1500ms debounce to keep it from opening prematurely if the user
is typing the address, will increase by 750ms each time it's triggered
Closes dialog form after link created
@kirillt
Copy link
Member

kirillt commented Oct 2, 2023

@mberry Looks cool!

  • Probably word Add would look better than Save, saving could refer to the whole list (which is stored automatically but the user can be confused)

  • Automatic expanding is cool, but there is a delay before drawing title/description input boxes. Does it happen only once we've have loaded the automatic values? Probably we should draw input boxes immediately, so the user can override title without waiting for the response from OGP. Saving before receiving the response from OGP should be possible, too. Overriden fields should not be replaced by automatic text.

  • Handling ctrl+v is a great idea, but in my experience it doesn't expand. I also receive false "There is already a link with the same URL" alert.

  • Another false alert:

    1. Open "save" dialog
    2. Paste a link.
    3. Wait until title and description are loaded
    4. Erase link input
    5. Hide "save" dialog
    6. "Failed to fetch website data"

@kirillt kirillt assigned mberry and Rizary and unassigned mberry Oct 16, 2023
@kirillt kirillt changed the title Seperate Link Creation Dialog #13, #21: Seperate Link Creation Dialog Feb 6, 2024
@kirillt kirillt changed the title #13, #21: Seperate Link Creation Dialog #13: Seperate Link Creation Dialog Feb 6, 2024
@kirillt kirillt assigned gwendalF and unassigned Rizary Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants