Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open fresh folders with .link files #46

Open
kirillt opened this issue Sep 23, 2023 · 3 comments
Open

Can't open fresh folders with .link files #46

kirillt opened this issue Sep 23, 2023 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@kirillt
Copy link
Member

kirillt commented Sep 23, 2023

By "fresh" I mean folders without .ark subfolder. This means there is any link lacks metadata and preview. Half-initialized folders must be openable, too. In other words, user should be able to copy-paste file externally into the folder and we should catch up with all missing data.

What we do in case a link lacks metadata:

  • If the link is not mentioned in user/properties, we query OGP and record all required fields into cache/metadata
  • If the link also lacks data in user/properties, then we query OGP for missing fields and put them into cache/metadata
  • If the link has all necessary fields in user/properties, then we don't query OGP

What we do in case a link lacks preview:

  • We just download it and put into cache/previews
@kirillt kirillt added enhancement New feature or request bug Something isn't working labels Sep 23, 2023
@Rizary
Copy link
Collaborator

Rizary commented Jan 21, 2024

@kirillt can you give me the logic for this bug?

@kirillt
Copy link
Member Author

kirillt commented Jan 22, 2024

@Rizary oh, I forgot that we already have this issue registered here. I think, we've discussed it during the call. The idea is that .link files can come externally, i.e. if the user just copies them in a file browser, or saves from a messenger, etc.

In this case, first launch should request all metadata, put it into cache/metadata storage and use as fallback for properties. The user is free to override the title/description and such values should be stored in user/properties. We need spinning circles to demonstrate that there are internet requests running in background about particular links. We also need to make title optional.

@shubertm
Copy link
Member

shubertm commented Mar 26, 2024

vokoscreenNG-2024-03-26_13-58-11.mp4

May be related to this issue but I created my links using Shelf itself. And they fail to open when I want to browse them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants