Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user about existence of pasted URL #22

Open
kirillt opened this issue Aug 28, 2022 · 3 comments
Open

Notify user about existence of pasted URL #22

kirillt opened this issue Aug 28, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@kirillt
Copy link
Member

kirillt commented Aug 28, 2022

ARK-Builders/ARK-Shelf#24
User should get input box highlighted when they paste URL which is already among saved links. Attempt to save such a link should result in an error message, or edit dialog spawned with older version of the link.

@kirillt kirillt added the enhancement New feature or request label Aug 28, 2022
@kirillt
Copy link
Member Author

kirillt commented Sep 6, 2023

Open questions:

  • just match resource ids or compare URLs?
  • should we strip query parameters before comparison?

@gwendalF
Copy link
Collaborator

@kirillt Is there a difference between ressource ids or URLs? It depends the behavior but I think we should keep full URL because it can resolve in different pages. For examples if query is used to filters some result may be that"s the result we are interested in

@kirillt
Copy link
Member Author

kirillt commented Sep 22, 2023

@gwendalF basically resource ids approximate URLs pretty well, i.e.:

  1. if id1 = id2 then url1 = url2 with 99.99% chance
  2. if id1 ≠ id2 then url1 ≠ url2 with 99.99% chance

We can ignore potential collisions for this moment. Later, we'll create more sophisticated ResourceId in arklib.

I also think we should not strip query parameters. I had this idea, but URL can change significantly if we remove parameters from it. Better to implement grouping by domain.

@kirillt kirillt moved this to Todo in Development Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants