Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logging from Log class with Timber #397

Open
hieuwu opened this issue Oct 17, 2023 · 1 comment
Open

Replace logging from Log class with Timber #397

hieuwu opened this issue Oct 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@hieuwu
Copy link
Collaborator

hieuwu commented Oct 17, 2023

With Timber we can log with current scope of the class. This helps find problem quickly and also make the log only available in DEBUG build.

@hieuwu hieuwu added the enhancement New feature or request label Oct 17, 2023
@hieuwu hieuwu self-assigned this Oct 17, 2023
@kirillt kirillt moved this to Todo in Development Oct 20, 2023
@kirillt
Copy link
Member

kirillt commented Dec 22, 2023

@hieuwu I remember considering Timber a while ago, but here are reasons why we haven't proceeded with it previous time:

  1. Finding the problematic class by log message is not that difficult task.
  2. Just filtering logs out from production build can be done using 4 lines of ProGuard.
  3. Extra dependency and minor refactoring needed to replace logs.

Here is a really cool use-case for Timber though:

  • In a release build, send errors and warning to our server (we must watch that logs on this level don't contain sensitive information).

But if we install a metrics server, e.g. AppDynamics, do we really need Timber to send errors there? Or AppDynamics can do it alone?

@kirillt kirillt moved this from Todo to In Progress in Development Jan 2, 2024
@kirillt kirillt moved this from In Progress to Todo in Development Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants