Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge _prob_params and Castro's _cpp_parameters #2686

Open
zingale opened this issue Dec 19, 2023 · 1 comment
Open

merge _prob_params and Castro's _cpp_parameters #2686

zingale opened this issue Dec 19, 2023 · 1 comment
Labels

Comments

@zingale
Copy link
Member

zingale commented Dec 19, 2023

Right now, we have a different make rule / mechanism for generating the problem parameters (looking that the problem's _prob_params file) than we do for all of the other Castro parameters. The parameter files are basically the same, so we should just merge this into a single process, all handled by the main Castro parameters.

This will make #2685 easier

@zingale
Copy link
Member Author

zingale commented Dec 19, 2023

actually, this is a little bit tricky, since the _prob_params support arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant