-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform gradient checks for SBML test suite #1236
Comments
We used to have an FD implementation with automatic step-size detection in PESTO. maybe it would be good to have something like that as a little python file/package also within AMICI? This way, pyPESTO could use it right away, because this would also be helpful there... |
FD with automatic step-size should definitely be implemented, not sure whether it makes more sense in AMICI or pyPESTO (where the final objective function is defined) 🤔 |
Depends on the definition of "final"... Would argue for AMICI:
|
For me also fine to have that as a (tiny) separate package. Might be useful elsewhere. Good if it's usable in pyPESTO without having to install AMICI. And I'd strongly argue for not creating circular dependencies between AMICI and pyPESTO, so rather not putting it into pyPESTO. Regarding C++ vs Python: I'd guess that the benefit of using C++ there is not big enough to justify two implementations, once in C++ for AMICI stuff and once for in Python for functions beyond single AMICI simulations. |
https://github.com/wesselb/fdm might help with this |
Motivated by #1230
Should be done for both forward and adjoint sensitivities (#18).
The text was updated successfully, but these errors were encountered: