Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia suit glow doesn't appear during cutscene #118

Open
Miepee opened this issue Sep 18, 2022 · 2 comments
Open

Varia suit glow doesn't appear during cutscene #118

Miepee opened this issue Sep 18, 2022 · 2 comments
Labels
bug Something isn't working the way it should

Comments

@Miepee
Copy link
Contributor

Miepee commented Sep 18, 2022

Describe the bug
During the "get varia suit" cutscene, Sarah is supposed to have a glow around her. This got borked during the reconsuction I believe.

To Reproduce
Obtain the varia suit

Expected behavior
During the cutscene, Sarah should have a white glow around her.

Media
Cutscene with it being gone
https://cdn.discordapp.com/attachments/885758931803193344/945882115147448330/GlowGone_SF16.mp4

Cutscene with it being there
https://youtu.be/7yzByD7_v9g?t=1426 (23:47)

Platform (please complete the following information):
All

Game Version:
1.5.5

Additional context
Discovered by Monody in Discord:
https://discord.com/channels/297870727422541826/885758931803193344/945882115847905300

@Miepee Miepee added the bug Something isn't working the way it should label Sep 18, 2022
@Jesright73
Copy link
Contributor

Fix for this issue:
oSuitChangeFX step event

if (state == 3)
{
    if (bg3alpha < 1)
        bg3alpha += 0.05;
    else
    {
        state = 4;
        bg3alpha = 1;
        bg1alpha = 0;
        if instance_exists(oFakeItemBall)
        {
            with (oFakeItemBall)
                instance_destroy();
        }
+       instance_create(x, y, oSuitChangeFX2);
        if (global.SuitChangeGravity == 0)
            scr_variasuitswap();
        else
            global.currentsuit = 2;
    }
}

@Jesright73
Copy link
Contributor

There is also a mistake in the create event of oSuitChangeFX2
image_index is used where sprite_index should be.

gml_Object_oSuitChangeFX2_Create_0

if (oControl.mod_fusion == 1)
-    image_index = 1133
+    sprite_index = sSuitChangeFX2_fusion 
alarm[0] = 60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way it should
Projects
None yet
Development

No branches or pull requests

2 participants