Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo to install taplo #1123

Closed
wants to merge 1 commit into from
Closed

Conversation

vivekvpandya
Copy link
Contributor

No description provided.

@eightfilms
Copy link
Contributor

Seems like the failure stems from tamasfe/taplo#473. Doesn't seem like maintainer(s) are updating the repo, unfortunately :/ we should probably look for an alternative?

@eightfilms
Copy link
Contributor

See: tamasfe/taplo#403

@matthiasgoergens
Copy link
Collaborator

We only use taplo for toml formatting. So it's not super important. We can use an alternative, or we can drop it.

@eightfilms
Copy link
Contributor

We only use taplo for toml formatting. So it's not super important. We can use an alternative, or we can drop it.

It looks like there are some efforts in reviving the project. However, for now, I'm of the opinion that we can drop it, since like you said it's only used for formatting. We can comment it out with a note to uncomment the CI when the new release is ready.

@vivekvpandya
Copy link
Contributor Author

I think there are prebuilt binaries for macos too, so may be we can detect which OS is in action.yaml and based on that install correct binary correctly?

@matthiasgoergens
Copy link
Collaborator

Closing this in favour of #1144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants