Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel ROM table and chiplets bus are broken #1545

Open
plafer opened this issue Oct 23, 2024 · 2 comments
Open

Kernel ROM table and chiplets bus are broken #1545

plafer opened this issue Oct 23, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Oct 23, 2024

The chiplet virtual table doesn't sum to 1 (due to the kernel ROM part) when there is more than 1 kernel procedure exported.

Failing test:

#[test]
fn simple_syscall_2() {
    let kernel_source = "
        export.foo
            add
        end
        export.bar
            mul
        end
    ";

    let program_source = "
        begin
            syscall.foo
            syscall.bar
        end";

    // TODO: update and use macro?
    let mut test = Test::new(&format!("test{}", line!()), program_source, false);
    test.stack_inputs = StackInputs::try_from_ints([3, 2, 1]).unwrap();
    test.kernel_source = Some(
        test.source_manager
            .load(&format!("kernel{}", line!()), kernel_source.to_string()),
    );
    test.expect_stack(&[9]);

    test.prove_and_verify(vec![3, 2, 1], false);
}

The chiplets bus is also broken (some miden-base tests trigger a bug we don't catch in our tests).

@plafer plafer added the bug Something isn't working label Oct 23, 2024
@bobbinth bobbinth added this to the v0.11.0 milestone Oct 23, 2024
@bobbinth
Copy link
Contributor

Not the same issue but maybe related: the check for block stack table was disabled in #1553 (comment) because it also seems to have an issue.

@bobbinth
Copy link
Contributor

Do we still need to address TODO here to close this issue?

@plafer plafer changed the title Kernel ROM trace and/or kernel table is broken Kernel ROM table and chiplets bus are broken Oct 31, 2024
@bobbinth bobbinth modified the milestones: v0.11.0, v0.12.0 Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants