Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly constrain u32 values #1484

Open
plafer opened this issue Sep 9, 2024 · 1 comment
Open

Properly constrain u32 values #1484

plafer opened this issue Sep 9, 2024 · 1 comment
Labels
air Related to Miden AIR and constraints

Comments

@plafer
Copy link
Contributor

plafer commented Sep 9, 2024

As discussed in #1480 (review), AIR constraints currently don't verify that u32 values are $< 2^{32}$. We should enforce that in the constraints.

@plafer plafer added bug Something isn't working air Related to Miden AIR and constraints labels Sep 9, 2024
@bobbinth
Copy link
Contributor

bobbinth commented Sep 9, 2024

I wouldn't probably call this a bug - more like a sub-optimal design choice :)

Btw, to make sure that all inputs are u32 values, we'd need perform additional range checks (2 range checks per operand). This shouldn't be too bad once we have LogUp-GKR integrated. But we'll also need to add more helper registers - and I'm not yet sure how to do this efficiently.

@plafer plafer removed the bug Something isn't working label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
air Related to Miden AIR and constraints
Projects
None yet
Development

No branches or pull requests

2 participants